-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix type of nonce in account #121
base: main
Are you sure you want to change the base?
Fix type of nonce in account #121
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
User description
Fix type of nonce in account
Nonce was returning a BN, I parse it to bigint and made a parseBN function
PR Type
Bug fix, Enhancement
Description
nonce
in account by parsing it tobigint
using a newparseBN
function.AccountData
type to reflect the change fromBN
tobigint
fornonce
.parseBalance
function to utilize the newparseBN
function for consistency.Changes walkthrough 📝
account.ts
Fix nonce type by parsing with parseBN
packages/auto-consensus/src/account.ts
parseBN
function to parse nonce.nonce
to useparseBN
.account.ts
Update nonce type to bigint
packages/auto-consensus/src/types/account.ts
nonce
type fromBN
tobigint
.parse.ts
Add parseBN function and update parseBalance
packages/auto-consensus/src/utils/parse.ts
parseBN
function to convertBN
tobigint
.parseBalance
to useparseBN
.